Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test upstream aws4fetch #43

Merged
merged 4 commits into from
Oct 18, 2023
Merged

Test upstream aws4fetch #43

merged 4 commits into from
Oct 18, 2023

Conversation

outscale-mdr
Copy link
Contributor

@outscale-mdr outscale-mdr commented Oct 17, 2023 •
edited
Loading

This PR is to use upstream aws4fetch to bypass a compilation errors (unexplained). When npm resolves the modules, with our aws4fetch fork stored on github, we end up with these errors:

67 error code 2
68 error git dep preparation failed
69 error command /usr/local/bin/node /usr/local/lib/node_modules/npm/bin/npm-cli.js install --force --cache=/home/node/.npm --prefer-offline=false --prefer-online=false --offline=false --no-progress --no-save --no-audit --include=dev --include=peer --include=optional --no-package-lock-only --no-dry-run
70 error > [email protected] prepare
70 error > npm run build
70 error
70 error
70 error > [email protected] build
70 error > npm run declaration && rollup -c
70 error
70 error
70 error > [email protected] declaration
70 error > tsc -p declaration.tsconfig.json
70 error
70 error node_modules/@types/node/globals.d.ts(325,84): error TS2792: Cannot find module 'undici-types'. Did you mean to set the 'moduleResolution' option to 'node', or to add aliases to the 'paths' option?

We have tried the following:

  • Use other method to retrive the aws4fetch (local and registry) => OK
  • Add "moduleResolution": "node" in tsconfig.conf in our fork => Ok but why do we need this

Even if we haven't found an answert to the problem, we actually do not need to modify the aws4fetch therefore we can use the upstream one.

The second task is to actually fix examples. They were actually compilation errors due to type for node examples. In order to get the support of crypto and fetch, we use the latest node version available (20.5.X) (see aws4fetch#22).

@outscale-mdr
Test upstream aws4fetch
4414445 
Signed-off-by: Maxime Dufour <[email protected]>
@outscale-mdr
Fix example
c18d739 
Signed-off-by: Maxime Dufour <[email protected]>
@outscale-mdr outscale-mdr temporarily deployed to eu-west-2 October 17, 2023 12:06 — with GitHub Actions Inactive
@outscale-mdr
Fix regen
7454418 
Signed-off-by: Maxime Dufour <[email protected]>
@outscale-mdr outscale-mdr temporarily deployed to eu-west-2 October 17, 2023 15:24 — with GitHub Actions Inactive
@outscale-mdr
Test all examples
bb5452a 
Signed-off-by: Maxime Dufour <[email protected]>
@outscale-mdr outscale-mdr temporarily deployed to eu-west-2 October 18, 2023 07:33 — with GitHub Actions Inactive
@outscale-mdr outscale-mdr merged commit 4cf77c9 into main Oct 18, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@outscale-mgo outscale-mgo outscale-mgo approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@outscale-mdr @outscale-mgo